-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SimHitsCaloHitsDumper #22192
Fix SimHitsCaloHitsDumper #22192
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22192/3340 |
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@civanch This analyser is not running in any test/production wf to my knowledge, so its effect should be null. It may be tested with the cfg provided (just used for MTD simulation development) |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Restore the functionality of this old analyser to quickly dump Sim Hits and Calo Hits from an event.
Add FastTimer hits to the collections to be considered.